-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup #737
base: master
Are you sure you want to change the base?
Rollup #737
Conversation
Can you explain what rollup is and why we should use it? Anyways, I agree with most of your points. We definitely should restructure code at the same time as translating it form CoffeeScript to JS, which is precisely why automating that task is only somewhat helpful.
Yeah, that's pretty bad...
Eh, those are whatever -- in theory we shouldn't rely on those being in the global context (just like the
👍
Eh, not so sure about that. Most Atom packages aren't that great to interface with (and/or provide an awful UX).
Hm, not sure what you mean here. I think we should make sure to (re-) design everything with lazy-loading and as much asynchronicity in mind -- it's pretty hard to shoehorn that in afterwards without making a mess of everything.
👍 |
It is a bundler similar to Webpack, but with better plugins. It reduced the load time (even now that the code has many issues) to half of its time. So once the Junos
Here I meant relying on deferring execution isn't good when the codebase already has other issues. It should be tried after.
That is why you opened the source of the packages. People will put time on helping the package improve.
Regarding the Atom's performance, people complain about it all over the internet. Many (including the actual Atom developers) have already switched to other platforms! We should all write performant code, especially when we gain a lot with very minor adjustments (like |
This is another proof of how and why the performance of
atom-julia-client
is suffering from the old JavaScriptsm and new wrong decisions.Despite building, it throws all sorts of warnings and errors because of these wrong habits.
Circular dependencies are spread all over the codebase:
Many unresolved dependencies:
Many other dynamic
requires
that I tried to solve using plugins.My suggestion for this repository:
exports/imports
dynamic require
.dynamic import
inside a condition (if
)linter
,atom-ide
packages, etc. Modularity is the best development approach.